Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync jupyterlab theme with OS client settings #734

Open
xgdgsc opened this issue Dec 5, 2023 · 6 comments
Open

sync jupyterlab theme with OS client settings #734

xgdgsc opened this issue Dec 5, 2023 · 6 comments

Comments

@xgdgsc
Copy link
Contributor

xgdgsc commented Dec 5, 2023

Can it sync jupyterlab light/dark theme with OS? When using browser with dark reader extension. It can sync with OS.

@JasonWeill
Copy link

@mbektas noted that there's a "Sync JupyterLab theme" option in prefs: #543 (comment)

Which theme option do you have selected in the Settings window? Which OS and which JupyterLab Desktop version are you running?

@xgdgsc
Copy link
Contributor Author

xgdgsc commented Dec 13, 2023

Yes I have that enabled and not working on Windows with auto dark mode installed. I use latest release jupyterlab-desktop with a remote ssh forwarded session. Does the option only work with local sessions?

@mbektas
Copy link
Member

mbektas commented Dec 17, 2023

@xgdgsc yes, the sync theme is designed to work for locally launched sessions or remote sessions that were launched with --expose-app-in-browser.

@xgdgsc
Copy link
Contributor Author

xgdgsc commented Dec 18, 2023

Thanks for the tip for --expose-app-in-browser . Would it be better if adding that tip to the settings UI?

@xgdgsc
Copy link
Contributor Author

xgdgsc commented Dec 18, 2023

It seems only work when reopen the session. Can it be made work with working inside the session , when system switches, do the switch? Just like other apps like vscode/edge can do.

@mbektas
Copy link
Member

mbektas commented Dec 18, 2023

@xgdgsc --expose-app-in-browser is mainly intended for testing launches and used by desktop app as well. It is not suggested for general use cases.
Some setting changes do not really require restarts and can be applied in place, but we didn't get chance to optimize. Something to improve in future.

@JasonWeill JasonWeill changed the title sync jupyterlab theme with OS? sync jupyterlab theme with OS client settings Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants