Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RunnableWithMessageHistory import #980

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix RunnableWithMessageHistory import #980

merged 1 commit into from
Sep 9, 2024

Conversation

krassowski
Copy link
Member

Fixes #978 by restoring import conventions as used in langchain documentation for RunnableWithMessageHistory.

@krassowski krassowski added the bug Something isn't working label Sep 7, 2024
dlqqq
dlqqq approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krassowski Awesome catch, thank you! 🤗

@dlqqq dlqqq enabled auto-merge (squash) September 9, 2024 20:13
@dlqqq dlqqq merged commit ad6f3a3 into jupyterlab:main Sep 9, 2024
8 checks passed
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
@krassowski @Marchlak
Fix RunnableWithMessageHistory import (jupyterlab#980)
db66844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot import name 'RunnableWithMessageHistory' from 'langchain_core.runnables'
2 participants
@krassowski @dlqqq