Add root package as Nx project #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
commented
Mar 4, 2023
Comment on lines
+24
to
26
| "nx": { | ||
| "includedScripts": [] | ||
| } |
There was a problem hiding this comment.
This configuration that tells Nx to not include root package scripts as Nx targets is required to stop root package scripts from causing an infinite loop. For example, yarn build on root calls lerna run build, which calls yarn build on root, etc. Now, lerna run build does not run on the root project because no targets are defined for that project.
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
* add package root to workspaces * configure Nx to not include root scripts as Nx targets
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* add package root to workspaces * configure Nx to not include root scripts as Nx targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lerna versiondoes not bump the version of the root package by default. It requires the root package to be listed as an Nx project by declaring it as a workspace inpackage.json. The root package version needs to be bumped because that is the version used bybuild-changelogin Jupyter Releaser.Linked PRs: