-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General UI/UX improvements #70
Conversation
@ellisonbg The background color in light mode does not have a good contrast, also it differs in how editor in notebook and markdown preview shows code blocks. Code blocks don't have any background in the editor; should we just add a minimal border around the code block to separate it? Another option might be to put a gray background, like we have for the cell block. I would also decrease the spacing between the code block and |
@3coins yep, good feedback on the code block styling. I want to wait for a separate PR to make those changes. We have new UI mocks coming for that part and the styling is going to be a bit different as we are using react markdown (I think an extension of it) for that part. I will open up a follow on issue for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
* Lots of minor UI/UX work. * Use chat icon. * Improved font colors in L/D themes. * Restore the widget as the active side panel if expanded.
* Lots of minor UI/UX work. * Use chat icon. * Improved font colors in L/D themes. * Restore the widget as the active side panel if expanded.
I went through most of the UI/UX and improved the behavior and styling. Some highlights:
Here is the current state: