Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump all project versions in bump-version #10

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Mar 5, 2023

By default, lerna version doesn't bump the version of projects that weren't changed since the last git-tagged release commit.

This PR adds a shell script that creates and stages a temporary file in each workspace, bumps the version, and then deletes the temporary file. This ensures all project versions are bumped in lock-step.

The only side-effect, besides the obvious performance degradation, is that jupyter releaser bump-version now bumps a few extra patch versions, because this command is run once per Python package listed under tool.jupyter-releaser.options.python_packages. See below:

% jupyter releaser bump-version
jupyter-releaser configuration loaded from .jupyter-releaser.toml.


--------------------------------------------------


bump-version




--------------------------------------------------
Using default value for version_spec: ''
Adding option override for --version-cmd: '../../scripts/bump-version.sh
Using default value for changelog_path: 'CHANGELOG.md'
Adding option override for --python-packages: '['packages/jupyter-ai:jupyter-ai', 'packages/jupyter-ai-dalle:jupyter-ai-dalle']
Using default value for help: 'False'
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


COMMAND: ../../scripts/bump-version.sh patch
lerna notice cli v6.5.1
lerna info current version 0.1.0
lerna notice FYI git repository validation has been skipped, please ensure your version bumps are correct
lerna info Looking for changed packages since v0.1.0
lerna info version rooted leaf detected, skipping synthetic root lifecycles
lerna WARN version Skipping working tree validation, proceed at your own risk

Changes:
 - @jupyter-ai/monorepo: 0.1.0 => 0.1.1 (private)
 - @jupyter-ai/dalle: 0.1.0 => 0.1.1
 - @jupyter-ai/core: 0.1.0 => 0.1.1

lerna info auto-confirmed
lerna info execute Skipping git tag/commit
lerna info execute Skipping git push
lerna info execute Skipping releases
lerna success version finished
rm 'packages/jupyter-ai/TEMP'
rm 'packages/jupyter-ai-dalle/TEMP'
0.1.1
0.1.1
COMMAND: ../../scripts/bump-version.sh patch
lerna notice cli v6.5.1
lerna info current version 0.1.1
lerna notice FYI git repository validation has been skipped, please ensure your version bumps are correct
lerna info Looking for changed packages since v0.1.0
lerna info version rooted leaf detected, skipping synthetic root lifecycles
lerna WARN version Skipping working tree validation, proceed at your own risk

Changes:
 - @jupyter-ai/monorepo: 0.1.1 => 0.1.2 (private)
 - @jupyter-ai/dalle: 0.1.1 => 0.1.2
 - @jupyter-ai/core: 0.1.1 => 0.1.2

lerna info auto-confirmed
lerna info execute Skipping git tag/commit
lerna info execute Skipping git push
lerna info execute Skipping releases
lerna success version finished
rm 'packages/jupyter-ai/TEMP'
rm 'packages/jupyter-ai-dalle/TEMP'
0.1.2
0.1.2

However, bumping the version with an explicit version specified by --version-spec still behaves as expected 😁

@dlqqq dlqqq added the bug Something isn't working label Mar 5, 2023
@dlqqq dlqqq merged commit 5351f1b into main Mar 5, 2023
@dlqqq dlqqq deleted the fix-bump-version branch March 5, 2023 20:11
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant