Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings to enable double duty Esc and to disable Shift-Esc override in Command mode #110

Merged
merged 5 commits into from
Sep 30, 2023

Conversation

firai
Copy link
Collaborator

@firai firai commented Sep 10, 2023

image

Comments are welcome.

@github-actions
Copy link

Binder 👈 Launch a Binder on branch firai/jupyterlab-vim/double-duty-escape

@krassowski krassowski added the enhancement New feature or request label Sep 10, 2023
@firai firai marked this pull request as ready for review September 13, 2023 05:40
Copy link
Collaborator

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to press submit on my review, sorry!

schema/plugin.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @firai, LGTM!

@krassowski krassowski merged commit 226d4b2 into jupyterlab-contrib:main Sep 30, 2023
6 checks passed
@firai firai deleted the double-duty-escape branch September 30, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants