-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Esc
does not work in visual mode
#104
Comments
hmm indeed. This seems to be another conflict with the documentsearch commands:
|
I can confirm, pressing Work-around: You can press |
I'm pretty sure that this and the others issues like will be resolved once jupyterlab 4.1 is released as that will include jupyterlab/jupyterlab#14421 |
Can you try adding #101 (comment) to your keyboard shortcut settings in the Advanced Settings Editor to see if it fixes the problem? The settings may need to be added at the top for them to take effect if you're keeping the full set of settings that JL populates by default. |
Is this solved jupyterlab 4.1 alpha ( |
I'm still getting the |
With search box open, or closed? |
With the search box closed. Once I open search box at least once, the error no longer shows up, but I still can't |
What are the scenarios that the |
In plain JupyterLab the scenario is as follows:
For jupyterlab-vim one could expect this to work as:
After testing your binders it indeed appears to work this way. The only problem I see is that when you open a text editor (rather than notebook) there is no step (4) which means that the search dialog cannot be dismissed without focusing on it. Any ideas? |
@krassowski, I see what you mean now. It would nice to be able to just keep pressing Esc to close the search box, but the fact that it doesn't in the file editor may not be a serious issue. Users who are accustomed to vim may be more likely to use What do you think about removing the bindings for now to fix core behavior for the plugin, and then file a new issue about this, in case someone comes up with a fix for this specific search box interaction later? @ianhi, thoughts? |
Could we try:
|
Sorry, by adding a CSS class when file editor is in visual/insert mode I meant hooking into the vim events/logic and adding a custom class to expose it to the selector. I think this should be possible but may be tricky. Depending on how difficult it is we may decide to go either way, but I would think that if this is not currently doable we should open an issue upstream. |
Sorry, I realized what you mean after I wrote the comment, so I deleted it. May be worth opening upstream anyway. |
Working on this custom hook is a bigger project than what I have time for right now. Are you available to work on this? If we don't expect to implement what you said in the near future, I would still propose that we remove the bindings for now (PR #107) so that we restore the core behavior of the plugin as a priority, and then leave what you're proposing as a future to-do. |
When in visual mode, I expect
Esc
to exit and return to the normal mode, but it does nothing.The text was updated successfully, but these errors were encountered: