-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a GitHub App for releasing with the Jupyter Releaser #67
Comments
FYI @fcollonval I was planning to start looking into this and create the GitHub App. Just checking if you had any preference on how to manage the secret for the app. Do you still have access to the Jupyter 1Password? If so we could maybe store the credentials there. |
@jtpio I don't have access to the 1Password account. But if most owners of this org have, I'm fine. Pinging @krassowski and @martinRenou for awareness |
I added a GitHub App. And yes the best for this org is for owners to generate private keys when migrating a repo to use the app for release. @jtpio I guess we can close the issue? |
Also thinking more about it, since I guess the "1 key per owner" approach sounds like the easiest for now. We can always delete, regenerate keys and update the |
We should look into following this change in Jupyter Releaser to avoid using the
ADMIN_GITHUB_TOKEN
: jupyter-server/jupyter_releaser#557This would mean creating an org wide GitHub app, and updating the releaser workflow and each repo to use the app.
The text was updated successfully, but these errors were encountered: