Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade test from latest release and from previous major version's latest release #868

Closed
consideRatio opened this issue Apr 4, 2023 · 1 comment · Fixed by #876
Closed

Comments

@consideRatio
Copy link
Member

consideRatio commented Apr 4, 2023

I think it should be quite easy to add an upgrade test from the latest release, since we already have an upgrade test from the default branch on github.

# Install TLJH from the default branch first to test upgrades
if upgrade:
run_container_command(
test_name, "curl -L https://tljh.jupyter.org/bootstrap.py | python3 -"
)
run_container_command(test_name, f"python3 /srv/src/bootstrap.py {installer_args}")

z2jh has three upgrade tests:

  1. from the latest dev release (for tljh this is equivalent to the main branch)
  2. from the latest stable release (the previous release)
  3. from the latest release of the previous major version

I figure it would make sense to have the same for tljh, where we currently have test 1 but is missing 2 and 3. (EDIT: see comment below, I think I'm incorrect - maybe we are testing 2 and not 1 currently?)

@consideRatio consideRatio changed the title Add upgrade test from latest release major version release Add upgrade test from latest release and from previous major version's latest release Apr 4, 2023
@consideRatio
Copy link
Member Author

In #842 (comment) @manics wrote:

The installer should install the last tagged version.... if you want to be absolutely sure then do an install and check the version is 0.2.0 and not:

version="1.0.0.dev0",

Is the plan to add up upgrade test in a future PR before tagging 1.0.0?

I've checked, curl -L https://tljh.jupyter.org/bootstrap.py | sudo -E python3 - --admin admin installs 0.2.0, curl -L https://tljh.jupyter.org/bootstrap.py | sudo -E python3 - --admin admin --version main installs the main branch


Based on that, I think I was incorrect in the comment above about what upgrade test we currently do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant