-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hostname in link printed to access the notebook server #325
Comments
+1 Following the instructions does not work:
There is no such server |
I'm +1 on bumping versions to latest as long as it doesn't break things. I guess in this case we should just make the |
It used to/currently print Instead of hard-coding things I'd check if we can turn off this behaviour via a flag. |
Is there any sort of work around for this? I'm working with biologists for example here |
I think with the default version of the notebook (v5.4) that repo2docker uses this does not happen. So my recommendation would be to stick with that instead of using the newer notebook v5.5 The way to move this forward is to help get this discussion to a point where there is consensus on how to handle this (configuration in the notebook or hardcoded command line argument or ...). |
is this something that either @takluyver or @minrk have insight on? |
There's work underway to make the address it prints configurable: jupyter/notebook#3668 What it printed before was right by coincidence, but with Docker it's a coincidence that comes up quite reliably, so this change has upset a few people. |
Thanks @takluyver. I agree with @AaronWatters that we should strive for a solution that has minimal impact on the end user. |
Thanks @betatim -- I can confirm that the problem doesn't occur if i use
|
From jupyter/notebook#3668 it looks like there will be a configuration option for this in notebook in the next release of the notebook. Currently repo2docker uses notebook v5.4 so we aren't yet impacted by this. I'd suggest we don't update the default version of the notebook to v5.5 and wait till jupyter/notebook#3668 has been merged and released. Then go straight for that version with the appropriate configuration set in the default command repo2docker executes. |
What it printed before was right sometimes by coincidence - if using something like docker-machine, or mapping any port other than the internal one, e.g. |
I'm +1 on holding off updating the notebook until we know this issue is resolvable |
In that case I'd be in favor of some sort of a solution where the host and port is decided "from the outside" and passed in to the container somehow (env vars?) and those passed in values are printed out when the server reports the connection URL. Sadly, I don't know the details on how to implement this, but I suspect it should be possible, maybe as some sort of a wrapper to |
Seems like when we switch to notebook 5.5 the link printed in the output will no longer work for people. See for example jupyter/docker-stacks#642
Two questions:
--hostname
argument to docker inrepo2docker
to belocalhost
or0.0.0.0
or something else entirely?The text was updated successfully, but these errors were encountered: