Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support registering as an extension for jupyter_server (alongside jupyter notebook) #177

Closed
2 tasks
consideRatio opened this issue May 5, 2021 · 0 comments · Fixed by #193
Closed
2 tasks
Milestone

Comments

@consideRatio
Copy link
Member

@damianavila pointed me to some relevant discussion that may or may not relate to #176, but should probably be addressed no matter what.

In this documentation for jupyter_server, there are notes on how to make a classical jupyter notebook extension register itself with jupyter_server.

https://jupyter-server.readthedocs.io/en/latest/developers/extensions.html#migrating-an-extension-to-use-jupyter-server

Based on the current setup.py file, I conclude that nbgitpuller currently isn't a extension compatible with both the classical notebook server and the new jupyter_server.

nbgitpuller/setup.py

Lines 25 to 27 in 207e3b2

data_files=[
('etc/jupyter/jupyter_notebook_config.d', ['nbgitpuller/etc/nbgitpuller.json'])
],

Suggested action points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant