Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package the jupyterlab extension with the Python package #233

Closed
consideRatio opened this issue Jan 10, 2021 · 5 comments · Fixed by #245
Closed

Package the jupyterlab extension with the Python package #233

consideRatio opened this issue Jan 10, 2021 · 5 comments · Fixed by #245
Assignees

Comments

@consideRatio
Copy link
Member

As @jtpio describes in #229 (comment), we can package the jupyterlab extension to install automatically as part of installing the python package!

@dipanjank
Copy link
Contributor

I'd like to work on this, if not taken already!

@consideRatio
Copy link
Member Author

@dipanjank greatly appreciated! Please mention me for review, I'd like to learn about this procedure :)

@jtpio
Copy link
Contributor

jtpio commented Jan 11, 2021

Thanks all!

Linking to a couple of resources that might help get this started:

@janjagusch
Copy link
Contributor

Hi! I'd also like to give this a try. :)

I would suggest to take inspiration from jupytext, where the JL extension has already been packages.

From what I could see I believe you need to

  • add a build:prod script to the package.json
  • change the setup.py to use jupyter_packaging

@jtpio
Copy link
Contributor

jtpio commented Feb 10, 2021

Nice, thanks @janjagusch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants