From 82e22b15a39509117be629f176524c9504a710f7 Mon Sep 17 00:00:00 2001 From: Erik Sundell Date: Tue, 25 Jun 2024 18:32:42 +0200 Subject: [PATCH] ci: update comment about running notebook v6 test with py311 --- .github/workflows/test.yaml | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 3f439c33..57c187a9 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -87,14 +87,18 @@ jobs: python-version: "3.8" pip-extras: lab - # FIXME: If https://github.com/jupyter/notebook/pull/7305 gets merged - # and released, we can test "classic" with python 3.12 as well, - # but until then we exclude it from being run as a Python 3.12 - # test and include it as a Python 3.11 test. + # pip-extras classic (notebook v6) isn't working with python 3.12 or + # later, so we exclude it here and then include it below to run with + # python 3.11 instead. - os: ubuntu-22.04 python-version: "3.12" pip-extras: classic include: + # Compensates for an excluded test case above + - os: ubuntu-22.04 + python-version: "3.11" + pip-extras: classic + # this test is manually updated to reflect the lower bounds of # versions from dependencies - os: ubuntu-22.04 @@ -106,11 +110,6 @@ jobs: tornado==6.1.0 traitlets==5.1.0 - # Workaround for excluded 3.12 test mentioned in a FIXME above - - os: ubuntu-22.04 - python-version: "3.11" - pip-extras: classic - steps: - uses: actions/checkout@v4