Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing versioneer? #558

Closed
yuvipanda opened this issue Jan 18, 2019 · 1 comment
Closed

Consider removing versioneer? #558

yuvipanda opened this issue Jan 18, 2019 · 1 comment

Comments

@yuvipanda
Copy link
Collaborator

I've had nothing but trouble with it when installing repo2docker from master or from a specific branch. For example, if you do:

pip install git+https://github.com/yuvipanda/repo2docker@julia-requirements

It thinks the version is jupyter-repo2docker-0.2.0+1064.ga3b7e95 which isn't true, and causes lots of other failures in other projects that depend on jupyter-repo2docker>0.7. There's also no easy way for me to debug this.

What value do we get from this somewhat large piece of code? Can we just use manual versioning instead?

yuvipanda added a commit to yuvipanda/datahub-old-fork that referenced this issue Jan 18, 2019
@betatim
Copy link
Member

betatim commented Jan 18, 2019

Let's see if we can debug this. The advantages of using it:

  • releasing requires creating a tag on the git CLI and pushing it
  • if you are running a branch/master repo2docker --version will report the precise revision you are using (handy for debugging)
  • i've never had to look at the code of versioneer, it seems to just work

cons:

  • it is a huge amount of code
  • none of us can debug it (realistically)
  • sometimes versioneer breaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants