-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI check to install with homebrew on macos
#7005
base: main
Are you sure you want to change the base?
Conversation
cc @defjaf Here are the logs for the homebrew installation, which passes on CI: https://github.com/jupyter/notebook/actions/runs/5809598910/job/15748922126?pr=7005 If you would like to double check to see if you have something similar locally. |
I get
Edit: But mine is actually using homebrew python, whereas yours is, I think, using the system python. |
And the rest of the logs? https://github.com/jupyter/notebook/actions/runs/5809598910/job/15748922126?pr=7005 |
I admit it's pretty hard to parse what I've got... So I attach a file with the console output from pip. Note that this is starting from having jupyterlab 3.6.3 and notebook 6.5.5 installed, so they are upgraded to 4.0.4 and 7.0.3 (but it didn't automatically upgrade other stuff). It does seem to have put a bunch of files below pip-install-notebook==7 output.txt Comparing to the CI logs for this PR, I note that "/opt" only appears in "/opt/hostedtoolcache" and that "brew" appears in some environment variables, in "brew install python" and the name of the issue itself. |
@jtpio Looking more carefully, even from the beginning of the logs, the CI is using |
Maybe we could check whether it's possible to install under And also add a Playwright test to check if the same schema errors appear in the browser console on CI. |
Well, I think the point is that the CI process isn't using the homebrew python and so not automatically picking up the homebrew paths like |
Or |
Seems like the CI machines are running on Intel, and that the same issues do not arise in that case, according to #7006. |
see #7006 (comment) for information about running in a venv. |
Troubleshoot #6974