From 434c5cb4cb7aedea971ee4464ecbbcf88fa873b5 Mon Sep 17 00:00:00 2001 From: Kevin Bates Date: Thu, 28 Jan 2021 15:52:59 -0800 Subject: [PATCH] Skip collection of terminal tests on Windows 3.9+ --- .github/workflows/python.yml | 2 +- notebook/conftest.py | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 notebook/conftest.py diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml index d427aa7355..92ee5d5214 100644 --- a/.github/workflows/python.yml +++ b/.github/workflows/python.yml @@ -11,7 +11,7 @@ jobs: fail-fast: false matrix: os: [ubuntu, macos, windows] - python-version: [ '3.6' , '3.7', '3.8', '3.9' ] # Windows 3.9 fails due to the pywinpty dependency not working + python-version: [ '3.6' , '3.7', '3.8', '3.9' ] # Windows 3.9 fails due to the pywinpty dependency not working (Issue #5967) steps: - name: Checkout uses: actions/checkout@v1 diff --git a/notebook/conftest.py b/notebook/conftest.py new file mode 100644 index 0000000000..2b1a913653 --- /dev/null +++ b/notebook/conftest.py @@ -0,0 +1,10 @@ + +import pytest + +import sys + +# TODO: Remove this hook once Issue #5967 is resolved. +def pytest_ignore_collect(path): + if str(path).endswith("test_terminals_api.py"): + if sys.platform.startswith('win') and sys.version_info >= (3, 9): + return True # do not collect