Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output cells no longer collapse completely #7020

Open
aodhanlutetiae opened this issue Aug 25, 2023 · 13 comments
Open

Output cells no longer collapse completely #7020

aodhanlutetiae opened this issue Aug 25, 2023 · 13 comments

Comments

@aodhanlutetiae
Copy link

Description

Version 7.0 doesn't allow user to collapse an output cell completely with a double click. This worked in 6.5.4. It is no longer possible in 7.0 (with either Firefox or Chrome).

Output is
output

Single click still collapse to window
single

Double click no longer collapses completely
double

Setup
Mac Ventura 13.5.1
Firefox 116.0.3, Chrome 116.0.5845.110
Jupyter 7.0, Jupyter 6.5.4

@aodhanlutetiae aodhanlutetiae added bug status:Needs Triage Applied to issues that need triage labels Aug 25, 2023
@jtpio
Copy link
Member

jtpio commented Aug 28, 2023

Thanks @aodhanlutetiae for opening the issue.

Notebook 7 allows collapsing output cells by clicking on the collapser on the left:

image

collapse-output.mp4

Would you be able to give it a try to see if that also works with your setup?

@aodhanlutetiae
Copy link
Author

Thanks @jtpio. I now see that the functionality is there (see image) insofar as it works via the menu (View / Collapse selected outputs) but clicking on the collapser does nothing in my setup (Mac Ventura 13.5.1, notebook 7.0.2, Firefox 117.0).

collapse

@jtpio
Copy link
Member

jtpio commented Aug 29, 2023

Would you be able to check if it is also an issue in JupyterLab?

If so we could move the issue there since Notebook 7 uses the JupyterLab notebook component.

@aodhanlutetiae
Copy link
Author

Just checked - it's not a problem in JupyterLab. The output cell collapses with a single click on the vertical blue bar.

@jtpio
Copy link
Member

jtpio commented Aug 30, 2023

Hmm that's strange, because Notebook 7 does not do anything special to the collapsers.

I'm starting a new release which would include the update to the JupyterLab 4.0.5 packages. Maybe that would fix the issue, although there doesn't seem to be any related changes in the release notes: https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.5

@jtpio
Copy link
Member

jtpio commented Aug 30, 2023

@aodhanlutetiae would you be able to try with 7.0.3? https://github.com/jupyter/notebook/releases/tag/v7.0.3

@ruan-takealot
Copy link

FWIW, on 7.0.3 I can only hide the code/output of the very first cell in the notebook (i.e. it works at least partially).
For any other cell in the notebook (both code and output) this does not work for me.

@jtpio
Copy link
Member

jtpio commented Aug 30, 2023

Indeed, this does not seem to be an issue with JupyterLab:

collapser-issue-notebook.mp4

@jtpio jtpio added this to the 7.0.x milestone Aug 30, 2023
@jtpio jtpio added help wanted and removed status:Needs Info status:Needs Triage Applied to issues that need triage labels Aug 30, 2023
@aodhanlutetiae
Copy link
Author

No change with Jupyter Notebook 7.0.3. As noted above, the blue bar will collapse input cell and output cell if it's the first cell in the notebook, but not after that.

@parasiitism
Copy link

Could you please consider assigning this issue to me? I am enthusiastic about getting involved in the project and am eager to collaborate with your team to help address this matter.

@jayeshsingh9767
Copy link
Contributor

@jtpio I am trying to fix this on my local notebook setup, could you please help with the module that handles this functionality, or is there any doc which i could refer understand where is this implemented?

@jtpio
Copy link
Member

jtpio commented Nov 22, 2023

@jtpio I am trying to fix this on my local notebook setup, could you please help with the module that handles this functionality, or is there any doc which i could refer understand where is this implemented?

Well not sure there is anything specific in Notebook 7 w.r.t the cell collapsers. Most of the code is in JupyterLab and Notebook simply reuses the extension. Unless some of the extensions specific to Notebook 7 conflict with it in some way.

@KenLee12323
Copy link

maybe adding "collapse cell output" to shortcut is even better.

@jtpio jtpio modified the milestones: 7.0.x, 7.4.0 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants