Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying HTML documents #6582

Closed
brichet opened this issue Oct 17, 2022 · 5 comments
Closed

Displaying HTML documents #6582

brichet opened this issue Oct 17, 2022 · 5 comments
Labels
Milestone

Comments

@brichet
Copy link
Contributor

brichet commented Oct 17, 2022

Describe the bug
The current document manager does not display properly HTML and PDF documents.
The HTML file are displayed as raw text instead of being interpreted.

To Reproduce
Open an HTML file from the tree view.

Expected behavior
Displaying the HTML file in a iframe, like it is in JupyterLab.

Screenshots
image

Additional context
Related to jupyter/nbgrader#1684

@brichet brichet added the bug label Oct 17, 2022
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Oct 17, 2022
@jtpio
Copy link
Member

jtpio commented Oct 17, 2022

Thanks @brichet for the report.

Probably the html-extension could be added to the application here:

"dependencies": {

pdf-extension seems to be listed in the dependencies, but maybe it's not properly included in the build.

@jtpio jtpio removed the status:Needs Triage Applied to issues that need triage label Oct 17, 2022
@jtpio jtpio added this to the 7.0 milestone Oct 17, 2022
@brichet
Copy link
Contributor Author

brichet commented Oct 17, 2022

Thanks @brichet for the report.

Probably the html-extension could be added to the application here:

"dependencies": {

pdf-extension seems to be listed in the dependencies, but maybe it's not properly included in the build.

Thanks for the suggestion @jtpio, it was enough for HTML Viewer.
I'm trying to figure out what's going on with the PDF, it seems that the docmanager.open command isn't catching the correct file type.

@jtpio
Copy link
Member

jtpio commented Oct 17, 2022

Thanks @brichet for the PRs, both #6584 and #6583 are now merged.

I'm happy to start a new Notebook 7 pre-release to help with jupyter/nbgrader#1684, unless there were a couple more fixes you wanted to submit first?

@brichet
Copy link
Contributor Author

brichet commented Oct 17, 2022

Thanks @jtpio.
I'm working on a way to open the file browser tab when changing the path from an other tab, and also to open the new tab by default after its creation.
So if you can wait a little longer, that would be great.

@brichet brichet closed this as completed Oct 17, 2022
@jtpio
Copy link
Member

jtpio commented Oct 17, 2022

Sounds good, thanks again 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants