Allow deleting nonempty directorys

[ghost]

Hello,
It is frequently useful to be able to delete non empty dirs, especially if there are many subfolders. Could you please add a feature for that (deleting nonempty dirs, maybe with a confirmation)?

[dsblank]

Now that delete will actually move to trash (coming in 5.3) we should allow Jupyter to delete non-empty directories.

[takluyver]

We should first check that send2trash actually allows you to send directories to trash on different platforms, not just individual files.

[blink1073]

I just verified with non-empty directories on macOS 10.13, Ubuntu 16.04, and Windows 10 using Send2Trash (1.4.1)

[blink1073]

In all cases I was able to delete and restore the folder.

[takluyver]

Thanks @blink1073 :-)

[damianavila]

In all cases I was able to delete and restore the folder.

Then, should be closing this one?

[jzf2101]

@takluyver is this ready to close?

[takluyver]

No, I think @blink1073 checked that the underlying code we're using is able to delete nonempty directories correctly. Someone still needs to enable that in our code before we can close it.

[hemangjoshi37a]

Has it been already solved??