From 75a0d71c28a3d66e99c5d3b8b7038d6d28885a65 Mon Sep 17 00:00:00 2001 From: Min RK Date: Fri, 18 Nov 2016 14:21:53 +0100 Subject: [PATCH] give the server a second to notice that the websocket closed because travis is slow --- .../services/kernels/tests/test_kernels_api.py | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/notebook/services/kernels/tests/test_kernels_api.py b/notebook/services/kernels/tests/test_kernels_api.py index 4548d6c953..3b97ec7303 100644 --- a/notebook/services/kernels/tests/test_kernels_api.py +++ b/notebook/services/kernels/tests/test_kernels_api.py @@ -1,6 +1,7 @@ """Test the kernels service API.""" import json +import time import requests from tornado.websocket import websocket_connect @@ -159,11 +160,18 @@ def test_kernel_handler(self): def test_connections(self): kid = self.kern_api.start().json()['id'] model = self.kern_api.get(kid).json() - assert model['connections'] == 0 + self.assertEqual(model['connections'], 0) ws = self.kern_api.websocket(kid) model = self.kern_api.get(kid).json() - assert model['connections'] == 1 + self.assertEqual(model['connections'], 1) ws.close() + # give it some time to close on the other side: + for i in range(10): + model = self.kern_api.get(kid).json() + if model['connections'] > 0: + time.sleep(0.1) + else: + break model = self.kern_api.get(kid).json() - assert model['connections'] == 0 + self.assertEqual(model['connections'], 0)