Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrictions in jupyter_client and jupyter_server dependencies necessary ? #1771

Closed
nklever opened this issue Mar 29, 2023 · 4 comments
Closed

Comments

@nklever
Copy link
Contributor

nklever commented Mar 29, 2023

@brichet: Thanks for the 0.8.2 update!

The dependency part of pyproject.toml restricts jupyter_client<8 and jupyter_server<2. Is this necessary, because of jupyter v2 compatibility ?

Thanks, Nik

@brichet
Copy link
Contributor

brichet commented Mar 29, 2023

I haven't had time to do any further introspection on these restrictions, but the tests fail when updating each of the packages:

@tuncbkose
Copy link
Contributor

tuncbkose commented Apr 4, 2023

For jupyter_client>=8 and timeout tests, jupyter/nbconvert#1964 is relevant.

Edit: oops, I misunderstood what you meant. But the linked issue was going to be a problem anyway. It should be fixed now

@luisarturopena
Copy link

The jupyter_server dependency issue breaks nbgrader when used with jupyter_server_terminals, which is needed for a lot of things. Hopefully this is fixed soon!

@brichet
Copy link
Contributor

brichet commented Mar 21, 2024

Closing as fixed by #1778 (released in 0.8.3) and #1684 (released in 0.9.0)

@brichet brichet closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants