Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test files missing in nbformat-5.1.2.tar.gz #213

Closed
arunpersaud opened this issue Jan 30, 2021 · 2 comments · Fixed by #252
Closed

test files missing in nbformat-5.1.2.tar.gz #213

arunpersaud opened this issue Jan 30, 2021 · 2 comments · Fixed by #252

Comments

@arunpersaud
Copy link

Hi

just trying to package this for openSUSE, but I'm getting the following error when using the pypi tar ball (preferred option)

=================================== FAILURES ===================================
[ 54s] __________________________ test_upgrade_v4_to_4_dot_5 __________________________
[ 54s]
[ 54s] def test_upgrade_v4_to_4_dot_5():
[ 54s] here = os.path.dirname(file)
[ 54s] > with io.open(os.path.join(here, os.pardir, os.pardir, 'tests', "test4.ipynb"), encoding='utf-8') as f:
[ 54s] E FileNotFoundError: [Errno 2] No such file or directory: '/home/abuild/rpmbuild/BUILD/nbformat-5.1.2/nbformat/v4/tests/../../tests/test4.ipynb'
[ 54s]
[ 54s] nbformat/v4/tests/test_convert.py:82: FileNotFoundError
[ 54s] _____________________________ test_sample_notebook _____________________________

Seems as if the tests are there, but the 'test' directory is missing. Can these be included again in the next release?

Thanks

Arun

@MSeal
Copy link
Contributor

MSeal commented Jan 31, 2021

Sure we can fix that. I forgot we were bundling the tests in the package tbh so I never double checked on their fixtures being included.

@opoplawski
Copy link

This is still an issue with 5.1.3. I'm working on updating the Fedora package and hitting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants