Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a toc for html and latex exporter #2178

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Add a toc for html and latex exporter #2178

wants to merge 29 commits into from

Conversation

HaudinFlorence
Copy link

@HaudinFlorence HaudinFlorence commented Sep 16, 2024 •
edited
Loading

Add a toc for html and latex exporter.

This PR fixes #1690.

When working on this PR, an correlated issue was opened in jupyterlab jupyterlab/jupyterlab#16795

@HaudinFlorence HaudinFlorence force-pushed the add_exporter_for_html_toc branch 3 times, most recently from 20a8394 to 16166f0 Compare September 16, 2024 11:52
@HaudinFlorence HaudinFlorence force-pushed the add_exporter_for_html_toc branch 2 times, most recently from 6bc676c to f7eb4c4 Compare September 16, 2024 16:38
@HaudinFlorence HaudinFlorence force-pushed the add_exporter_for_html_toc branch 3 times, most recently from 322c26c to 6b3946a Compare September 17, 2024 14:17
@HaudinFlorence HaudinFlorence marked this pull request as ready for review September 17, 2024 14:17
@HaudinFlorence HaudinFlorence marked this pull request as draft September 17, 2024 14:38
@HaudinFlorence HaudinFlorence force-pushed the add_exporter_for_html_toc branch 2 times, most recently from d16bad8 to 3fefaae Compare September 17, 2024 15:25
@HaudinFlorence HaudinFlorence force-pushed the add_exporter_for_html_toc branch 2 times, most recently from 2a3e213 to 5de2600 Compare September 18, 2024 09:56
@HaudinFlorence HaudinFlorence mentioned this pull request Sep 19, 2024
Closed
@martinRenou martinRenou self-requested a review October 4, 2024 09:20
martinRenou
martinRenou reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I don't have much to say, it looks good to me. I just have a tiny nitpicky comment about the CLI usage

@HaudinFlorence
Restore None check condition in HTML exporter instead of _init_resources
cdc2743 
Fix index.html.j2 to restore the style of the table of content.
@HaudinFlorence HaudinFlorence changed the title Add a toc for html exporter Add a toc for html and latex exporter Oct 9, 2024
@HaudinFlorence
Change method extract_titles_from_markdown_input to extract_titles_fr…
de2ff4e 
…om_notebook_node, include it in the resources dictionary and use it directly in the index.html.j2 template.
@HaudinFlorence HaudinFlorence force-pushed the add_exporter_for_html_toc branch 2 times, most recently from 9452783 to de2ff4e Compare October 14, 2024 12:21
@HaudinFlorence HaudinFlorence force-pushed the add_exporter_for_html_toc branch 5 times, most recently from 784598d to 8623ce8 Compare November 6, 2024 17:10
@HaudinFlorence
Change the logics to get the headers using parsing of the markdown ce…
e5d2da6 
…ll content to html and using BeautifulSoup.select.
@HaudinFlorence HaudinFlorence force-pushed the add_exporter_for_html_toc branch 5 times, most recently from c99c58d to 8e2a89f Compare November 7, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement format:HTML pertains to exporting to the HTML format format:LaTeX pertains to exporting to the LaTeX format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

command line argument for table of content.
2 participants
@HaudinFlorence @martinRenou