Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Upcoming: Ubuntu ≥ 23.04 (lunar) has user with UID 1000 #1877

Closed
benz0li opened this issue Feb 14, 2023 · 4 comments
Closed

[ENH] - Upcoming: Ubuntu ≥ 23.04 (lunar) has user with UID 1000 #1877

benz0li opened this issue Feb 14, 2023 · 4 comments
Labels
type:Enhancement A proposed enhancement to the docker images

Comments

@benz0li
Copy link
Contributor

benz0li commented Feb 14, 2023

What docker image(s) is this feature applicable to?

base-notebook

What changes are you proposing?

This feature applies to image docker-stacks-foundation as soon as ubuntu:24.04 is used as base image.

Proposal: Delete user with UID 1000 before https://github.com/jupyter/docker-stacks/blob/main/docker-stacks-foundation/Dockerfile#L70:

if $(grep -q 1000 /etc/passwd); then \
  userdel -r $(id -un 1000); \
fi && \

How does this affect the user?

This feature ensures that docker-stacks-foundation successfully builds with upcoming ubuntu:24.04.

Anything else?

docker run --rm -ti ubuntu:lunar cat /etc/passwd
root:x:0:0:root:/root:/bin/bash
daemon:x:1:1:daemon:/usr/sbin:/usr/sbin/nologin
bin:x:2:2:bin:/bin:/usr/sbin/nologin
sys:x:3:3:sys:/dev:/usr/sbin/nologin
sync:x:4:65534:sync:/bin:/bin/sync
games:x:5:60:games:/usr/games:/usr/sbin/nologin
man:x:6:12:man:/var/cache/man:/usr/sbin/nologin
lp:x:7:7:lp:/var/spool/lpd:/usr/sbin/nologin
mail:x:8:8:mail:/var/mail:/usr/sbin/nologin
news:x:9:9:news:/var/spool/news:/usr/sbin/nologin
uucp:x:10:10:uucp:/var/spool/uucp:/usr/sbin/nologin
proxy:x:13:13:proxy:/bin:/usr/sbin/nologin
www-data:x:33:33:www-data:/var/www:/usr/sbin/nologin
backup:x:34:34:backup:/var/backups:/usr/sbin/nologin
list:x:38:38:Mailing List Manager:/var/list:/usr/sbin/nologin
irc:x:39:39:ircd:/run/ircd:/usr/sbin/nologin
_apt:x:42:65534::/nonexistent:/usr/sbin/nologin
nobody:x:65534:65534:nobody:/nonexistent:/usr/sbin/nologin
ubuntu:x:1000:1000:Ubuntu:/home/ubuntu:/bin/bash
@benz0li benz0li added the type:Enhancement A proposed enhancement to the docker images label Feb 14, 2023
@benz0li
Copy link
Contributor Author

benz0li commented Feb 14, 2023

@mathbunnyru This can already be added preventively.

@mathbunnyru
Copy link
Member

Thank you, @benz0li!

We have more than a year before the ubuntu 24.04 release.
I suggest we wait because I think this might change before release, and we might not have this problem.

I don't like adding such a fix preventively, especially this early.
At the same time, I agree this is gonna be an issue if nothing changes and I think the fix you suggest is reasonable (though we might want to remove homedir as well).

@benz0li benz0li changed the title [ENH] - Upcoming: Ubuntu 24.04 (lunar) has user with UID 1000 [ENH] - Upcoming: Ubuntu > 23.04 (lunar) has user with UID 1000 Feb 14, 2023
@benz0li benz0li changed the title [ENH] - Upcoming: Ubuntu > 23.04 (lunar) has user with UID 1000 [ENH] - Upcoming: Ubuntu ≥ 23.04 (lunar) has user with UID 1000 Feb 14, 2023
@benz0li
Copy link
Contributor Author

benz0li commented Feb 14, 2023

I suggest we wait because I think this might change before release, and we might not have this problem.

Good point. This might change indeed.

[...] (though we might want to remove homedir as well).

True. I have updated the command.

@benz0li
Copy link
Contributor Author

benz0li commented Feb 15, 2023

Closed for now. I set a reminder for early 2024 😬.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement A proposed enhancement to the docker images
Projects
None yet
Development

No branches or pull requests

2 participants