Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated overview of docker images on dockerhub #1488

Closed
mathbunnyru opened this issue Oct 16, 2021 · 6 comments
Closed

Outdated overview of docker images on dockerhub #1488

mathbunnyru opened this issue Oct 16, 2021 · 6 comments
Labels
type:Bug A problem with the definition of one of the docker images maintained here

Comments

@mathbunnyru
Copy link
Member

What docker image you are using?

All of them

What complete docker command do you run to launch the container (omitting sensitive values)?

Not applicable

What steps do you take once the container is running to reproduce the issue?

  1. Visit https://hub.docker.com/r/jupyter/base-notebook

What do you expect to happen?

Beautiful webpage

What actually happens?

There is an outdated microbadge link, which is broken.

@mathbunnyru mathbunnyru added the type:Bug A problem with the definition of one of the docker images maintained here label Oct 16, 2021
@mathbunnyru
Copy link
Member Author

I don't have an access to edit the overview.
Actually, manual editing is not good - one day it might break again.

The solution is to use a github action to automatically update descriptions using README files in the repo:
https://github.com/marketplace/actions/update-container-description-action

@mathbunnyru
Copy link
Member Author

I will draft a PR soon, it seems to be easy.

@mathbunnyru
Copy link
Member Author

I've implemented it, but it won't work for now:
https://github.com/christian-korneck/update-container-description-action#conflict-with-dockerhub-personal-access-tokens-and-2fa-auth

@parente could you please update READMEs manually for now?

@mathbunnyru
Copy link
Member Author

Or maybe @consideRatio or @romainx have the rights to do this?

@parente
Copy link
Member

parente commented Oct 22, 2021

@mathbunnyru Done!

@mathbunnyru
Copy link
Member Author

@parente thanks, looks good! 👍

I would prefer automatic updates, but they do not seem to work at the moment, so closing this issue.
christian-korneck/update-container-description-action#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Bug A problem with the definition of one of the docker images maintained here
Projects
None yet
Development

No branches or pull requests

2 participants