Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider redoing all scripts with Xonsh #1233

Closed
maresb opened this issue Feb 7, 2021 · 5 comments
Closed

Consider redoing all scripts with Xonsh #1233

maresb opened this issue Feb 7, 2021 · 5 comments
Labels
type:Enhancement A proposed enhancement to the docker images type:Maintenance A proposed enhancement to how we maintain this project

Comments

@maresb
Copy link
Contributor

maresb commented Feb 7, 2021

I've become a big fan of the Xonsh shell scripting language. It allows for almost seamless mixing between Bash and Python. Thus you get the sanity of Python, but you can still simply run a command without needing subprocess.

I think it may provide a viable way forward for initiatives which have stalled out, such as #1052 and #1140.

@consideRatio
Copy link
Collaborator

I like the idea of sticking with Makefile/bash/python even though I don't yet know of Xonsh. I have grown fond whatever tech that can be understood using well known tech as it reduce the threshold to maintain and contribute to a project.

@mathbunnyru mathbunnyru added type:Enhancement A proposed enhancement to the docker images type:Maintenance A proposed enhancement to how we maintain this project labels Sep 30, 2022
@mathbunnyru
Copy link
Member

Hi @maresb!
Would you like to work on this feature? 😄

I think the most significant issues in our images reside in shell scripts currently (especially, in start.sh), and it would be nice to move to pure Python in the future, so to me, xonsh is an excellent intermediate step.
I think it might make fixing some issues easier.

@maresb
Copy link
Contributor Author

maresb commented Jun 6, 2023

Hey @mathbunnyru, thanks for thinking of me! I'm going to pass on this one though. (I have too much other stuff going on already.)

@mathbunnyru
Copy link
Member

Hey @mathbunnyru, thanks for thinking of me! I'm going to pass on this one though. (I have too much other stuff going on already.)

I totally get it ❤️

@mathbunnyru
Copy link
Member

Unfortunately, I think Xonsh won't help us very much.
It will definitely look nicer in some parts, like logging.
But we'll still have all the things with renaming user, and these are just calling linux user management utils like usermod.
On the other hand, we'll have to deal with xonsh vs bash differences and it'll be more difficult for the contributors to change start.sh (or start.xsh).
Here is the translation guide: https://xon.sh/bash_to_xsh.html

#1140 mentioned in the issue is solved though by using pure python scripts in tagging dir. (and I think it works beautifully now)

So, I'm closing this issue as not planned.

@mathbunnyru mathbunnyru closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement A proposed enhancement to the docker images type:Maintenance A proposed enhancement to how we maintain this project
Projects
None yet
Development

No branches or pull requests

3 participants