Skip to content
This repository has been archived by the owner on Oct 26, 2019. It is now read-only.

Support report layout #157

Closed
dalogsdon opened this issue Mar 24, 2016 · 5 comments
Closed

Support report layout #157

dalogsdon opened this issue Mar 24, 2016 · 5 comments
Assignees
Milestone

Comments

@dalogsdon
Copy link
Contributor

jupyter/dashboards#203 will introduce a simpler dashboard "report" layout:

Report mode: a simple view which shows cells in notebook order, single column and full width. The only action available to the user is whether to show/hide each cell.

We should support this layout once it is implemented in the dashboards notebook extension.

@dalogsdon dalogsdon added this to the 0.5.0 milestone Mar 24, 2016
@parente parente modified the milestones: 0.5.0, 0.6.0 Mar 24, 2016
@dalogsdon
Copy link
Contributor Author

Discussed with @jhpedemonte, and we decided that jupyter/dashboards#203 will be handled as a subset of the grid layout. Therefore, this should just automatically work in the dashboard server. We will probably just end up closing this issue after verifying that it works as expected.

@parente
Copy link
Member

parente commented Apr 6, 2016

Is the dashboard authoring for report mode computing height for each cell? Or will logic need to be added over here to interpret and compute the height of each output area?

I ask because #145 is about rendering notebooks that have NO layout metadata as if they were laid out top to bottom in report mode with all cells with output showing.

@dalogsdon
Copy link
Contributor Author

Yes, it should still be computing height.

@dalogsdon
Copy link
Contributor Author

jupyter/dashboards#203 is now handing report layout as a separate (non-Gridstack) layout. The dashboard server will have to handle this. This may now overlap with #145 a bit as the dashboard will default to the report layout if no dashboard layout metadata.

@parente
Copy link
Member

parente commented Apr 12, 2016

Probably best if @dalogsdon and @jameslmartin pair on the two items in tandem. Good intro for @jameslmartin too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants