Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLAnimation and WebGLInfo won't build on the master barnch #204

Closed
mprogram opened this issue Jul 29, 2018 · 2 comments
Closed

WebGLAnimation and WebGLInfo won't build on the master barnch #204

mprogram opened this issue Jul 29, 2018 · 2 comments

Comments

@mprogram
Copy link

My build output with the examples corresponds to that of Travis. However, I'm getting the following non-fatal errors, each emitted twice, while actually trying to build the master branch:

error creating wrapper:
Error: invalid class name: WebGLAnimation
. at getExtraDefines (~/jupyter-widgets/pythreejs/js/scripts/generate-wrappers.js:187:15)
. at new JavascriptWrapper (~/jupyter-widgets/pythreejs/js/scripts/generate-wrappers.js:330:34)
. at createJavascriptWrapper (~/jupyter-widgets/pythreejs/js/scripts/generate-wrappers.js:554:19)
. at Glob.<anonymous> (~/jupyter-widgets/pythreejs/js/scripts/generate-wrappers.js:261:26)
. at emitOne (events.js:116:13)
. at Glob.emit (events.js:211:7)
. at Glob._emitMatch (~/jupyter-widgets/pythreejs/js/node_modules/glob/glob.js:489:8)
. at Glob._processSimple2 (~/jupyter-widgets/pythreejs/js/node_modules/glob/glob.js:705:8)
. at ~/jupyter-widgets/pythreejs/js/node_modules/glob/glob.js:676:10
. at Glob._stat2 (~/jupyter-widgets/pythreejs/js/node_modules/glob/glob.js:789:10)
skipping: renderers/webgl/WebGLAnimation.js

and

error creating wrapper:
Error: invalid class name: WebGLInfo
. at getExtraDefines (~/jupyter-widgets/pythreejs/js/scripts/generate-wrappers.js:187:15)
. at new JavascriptWrapper (~/jupyter-widgets/pythreejs/js/scripts/generate-wrappers.js:330:34)
. at createJavascriptWrapper (~/jupyter-widgets/pythreejs/js/scripts/generate-wrappers.js:554:19)
. at Glob.<anonymous> (~/jupyter-widgets/pythreejs/js/scripts/generate-wrappers.js:261:26)
. at emitOne (events.js:116:13)
. at Glob.emit (events.js:211:7)
. at Glob._emitMatch (~/jupyter-widgets/pythreejs/js/node_modules/glob/glob.js:489:8)
. at Glob._processSimple2 (~/jupyter-widgets/pythreejs/js/node_modules/glob/glob.js:705:8)
. at ~/jupyter-widgets/pythreejs/js/node_modules/glob/glob.js:676:10)
. at Glob._stat2 (~/jupyter-widgets/pythreejs/js/node_modules/glob/glob.js:789:10)
skipping: renderers/webgl/WebGLInfo.js

Is is a known situation, and is it being tracked somewhere for further reference? Could it be safely ignored as for now?

BTW, three.js r94 has been released, and r95 is coming soon. Many thanks for keeping up with all your work!

@vidartf
Copy link
Member

vidartf commented Jul 30, 2018

Thanks for the report! From what I can tell, you are trying to build against r93 or later, without having updated the config. I think these errors should be safe to ignore, as these classes should likely be ignored anyway (i.e. not used in pythreejs).

For now, updating the three.js version requires a full manual scan of the changelogs to look for any changes that will affect pythreejs. Then an appropriate release version will have to be decided on, as pythreejs follows semver, while threejs does not. While this is not too much work, it is still enough that pythreejs is unlikely to follow threejs super-closely by default. However, if there are specific new features that people want, a simple request for an update via an issue should help push it along!

@vidartf
Copy link
Member

vidartf commented Sep 4, 2018

Closing as answered! Feel free to comment if there are any unanswered questions.

@vidartf vidartf closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants