1719 support more styles to toggle buttons #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongrout
reviewed
Nov 21, 2017
|
|
||
| button_color: str or None | ||
| The color of each button. This should be a valid CSS color unit, | ||
| e.g. 'yellow', '#FFFF00', '255,255,0'. |
There was a problem hiding this comment.
The rgb color should be of the form rgb(255,255,0), right? https://developer.mozilla.org/en-US/docs/Web/CSS/color
There was a problem hiding this comment.
Yes, you are totally right. Thanks for the catch! I will make updates accordingly.
|
Thanks! |
|
For future reference, this is fixing #1719. |
|
Testing the examples given reveals that the color trait won't take something like |
|
Thanks again! |
This was referenced Dec 5, 2017
Closed
|
Is this supposed to be merged in >>> display(widgets.Button().style.keys)
'_model_module',
'_model_module_version',
'_model_name',
'_view_count',
'_view_module',
'_view_module_version',
'_view_name',
'button_color',
'font_weight']
>>> display(widgets.ToggleButton().style.keys)
['_model_module',
'_model_module_version',
'_model_name',
'_view_count',
'_view_module',
'_view_module_version',
'_view_name',
'description_width'] |
lock
bot
added
the
resolved-locked
This is answered in #3268 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.