Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection widgets fixes #1822

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Conversation

SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Nov 17, 2017

Minor changes

  • button_style should not be allowed to be None.
  • The selected index in the selection container is allowed to be None. I think that the default value should be None (currently, it is 0, which does not make sense if no list of children was passed yet).

@jasongrout
Copy link
Member

I think in most cases, people will expect that if they create a dropdown, the first item will be selected by default.

Perhaps we should handle the (relatively rare?) case of no children separately.

@SylvainCorlay
Copy link
Member Author

The issue is that when we create a tab / accordion widget with no argument, the current default value does not make sense.

@SylvainCorlay
Copy link
Member Author

I don't see a simple means to have a consistent behavior other than setting the default to None.

@SylvainCorlay
Copy link
Member Author

I have rebased and removed the change to the selection container. Will open another separate PR for it for a 7.1.

@jasongrout jasongrout added this to the 7.0.x milestone Nov 17, 2017
@jasongrout
Copy link
Member

Thanks!

@jasongrout jasongrout merged commit d0ee1be into jupyter-widgets:master Nov 17, 2017
@SylvainCorlay SylvainCorlay deleted the selection branch November 17, 2017 18:26
@jasongrout jasongrout modified the milestones: 7.0.x, 7.1 Dec 18, 2017
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants