Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename .pWidget to .lmWidget #3087

Closed
jasongrout opened this issue Feb 5, 2021 · 2 comments · Fixed by #3118
Closed

Rename .pWidget to .lmWidget #3087

jasongrout opened this issue Feb 5, 2021 · 2 comments · Fixed by #3118
Labels
good first issue
Milestone
8.0

Comments

@jasongrout
Copy link
Member

To complete our transition to Lumino, perhaps we should rename the .pWidget attribute to .lmWidget? Or is that a bit gratuitous?
@jasongrout jasongrout added this to the 8.0 milestone Feb 5, 2021
@jasongrout
Copy link
Member Author

Perhaps for 8.0, .pWidget can be a deprecated alias to .lmWidget, removed in ipywidgets 9.0.

@jasongrout
Copy link
Member Author

To do this, I think we should:

  1. Search and replace pWidget for lmWidget (mostly in https://github.com/jupyter-widgets/ipywidgets/blob/master/packages/base/src/widget.ts, probably, but probably elsewhere in the typescript code too)
  2. Create a new getter for pWidget that returns lmWidget. We can document it as deprecated for now, and when we get closer to 9.0, we can start console.warning about its use.

@davidbrochart davidbrochart mentioned this issue Feb 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
8.0
Development

Successfully merging a pull request may close this issue.

Rename pWidget to lmWidget davidbrochart/ipywidgets
1 participant
@jasongrout