-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model spec out of date #1852
Comments
The only backwards-incompatible change is making nulls not possible in #1822. The real problem is that we aren't quite equipped to deal with compatible versions of the model spec quite yet. Some options:
|
Here's what I think I'll pursue:
|
Oh, and also: write a test that generates the spec from the python code, and fails if the spec in the repo does not match what is generated from the python code. That should catch any further incompatibilities from slipping in. |
Fixed by #1854. |
It looks like several PRs changed the model spec. We'll have to be more careful about this, perhaps with a test that generates the model spec and compares to the model spec document (which is also mostly auto-generated).
One released change:
style
kwarg #1714 addeddescription_width
to the ToggleButtonsStyleModel without updating the spec document. This was released in 7.0.1.Two unreleased changes:
button_color
andfont_weight
. (We should also test thebutton_color
one more time - the current theme I think changes the color slightly when the toggle item is selected, butbutton_color
may overwrite that.)In particular, I'm hesitant to release without resolving this issue for #1822 and #1834.
CC @SylvainCorlay
The text was updated successfully, but these errors were encountered: