Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection containers (Tab, accordion) should allow a selected index of None for consistency #1493

Closed
jasongrout opened this issue Jul 10, 2017 · 4 comments
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Member

This would make it consistent with the selection widgets.

@jasongrout jasongrout added this to the 7.0 milestone Jul 10, 2017
@pbugnion
Copy link
Member

The selection widgets explicitly disallow out of range indices.

Do we want to do that for the selection containers as well? It breaks backwards compatibility (I'm not sure how much user code relies on being able to set / get -1 for selected_index), but it would be more consistent and ensures that there's only one way to set the container as having nothing selected.

@jasongrout
Copy link
Member Author

Fixed by #1495.

@SylvainCorlay
Copy link
Member

@jasongrout I wonder if the default should not also be None. At the moment, for some reason, the default is 0.

@jasongrout
Copy link
Member Author

I think that would be confusing in most cases. Let's carry on discussion on #1822, though.

@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

3 participants