Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

y-py v0.5.5 from conda-forge breaks ydoc #143

Closed
hbcarlos opened this issue Feb 17, 2023 · 3 comments · Fixed by #145
Closed

y-py v0.5.5 from conda-forge breaks ydoc #143

hbcarlos opened this issue Feb 17, 2023 · 3 comments · Fixed by #145
Labels
bug Something isn't working

Comments

@hbcarlos
Copy link
Contributor

Due to the problem with the y-py aarch64 build (here: y-crdt/ypy#119). We published a new build of ypy v0.5.5 in conda-forge. This new build includes y-crdt/ypy#102, which changes the return type of the to_json and breaks jupyter_ydoc.

Task exception was never retrieved
future: <Task finished name='Task-175' coro=<YDocWebSocketHandler.maybe_save_document() done, defined at /Users/carlos/Documents/qs/rtc_dev/jupyterlab_collaboration/jupyter_collaboration/handlers.py:342> exception=TypeError('string indices must be integers')>
Traceback (most recent call last):
  File "/Users/carlos/Documents/qs/rtc_dev/jupyterlab_collaboration/jupyter_collaboration/handlers.py", line 365, in maybe_save_document
    if model["content"] != self.room.document.source:
  File "/Users/carlos/Documents/qs/rtc_dev/jupyter_ydoc/jupyter_ydoc/ybasedoc.py", line 60, in source
    return self.get()
  File "/Users/carlos/Documents/qs/rtc_dev/jupyter_ydoc/jupyter_ydoc/ynotebook.py", line 215, in get
    if "id" in cell and meta["nbformat"] == 4 and meta["nbformat_minor"] <= 4:
TypeError: string indices must be integers

The error above is caused by

meta = self._ymeta.to_json()
, because when installing y-py v0.5.5 from conda-forge, the to_json method returns a string.

@hbcarlos hbcarlos added the bug Something isn't working label Feb 17, 2023
@welcome
Copy link

welcome bot commented Feb 17, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@hbcarlos hbcarlos mentioned this issue Feb 17, 2023
@davidbrochart
Copy link
Collaborator

We published a new build of ypy v0.5.5 in conda-forge. This new build includes y-crdt/ypy#102

I think that's the issue, the conda-forge package for v0.5.5 should not include this PR, since it was not released yet.

@davidbrochart
Copy link
Collaborator

Ah I see, it was partly released in v0.5.5, which now have inconsistent wheels (aarch64 wheels have y-crdt/ypy#102 while others don't). We should have bumped the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants