Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor as ApiHandle class attribute #95

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 28, 2021

Follow-up to #93

Trying the latest locally, there seems to be a couple of warnings related to having the __del__ method:

Exception ignored in: <function ApiHandler.__del__ at 0x7ff024d01040>
Traceback (most recent call last):
  File "/path/to/miniforge3/envs/jupyter-resource-usage-release/lib/python3.9/site-packages/jupyter_resource_usage/api.py", line 23, in __del__
    super().__del__()
AttributeError: 'super' object has no attribute '__del__'

Looks like it should be fine to keep the previous behavior of having the executor as a class attribute.

cc @fcollonval

@fcollonval
Copy link
Member

Sorry for that one - usually I prefer to have thread shutdown explicitly controlled. But I'm fine with the rollback.

@jtpio
Copy link
Member Author

jtpio commented Apr 29, 2021

No problem, thanks for checking.

I think we can cut a new 0.6.0 release with this change and #93. And then potentially improve the handling of the executor separately.

@jtpio jtpio merged commit a72f1da into jupyter-server:master Apr 29, 2021
@jtpio jtpio deleted the executor branch April 29, 2021 09:51
@jtpio jtpio added this to the 0.6.0 milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants