Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update mitigation of file editors extensionFactory issue before release #1060

Closed
krassowski opened this issue Feb 25, 2024 · 0 comments · Fixed by #1061
Closed

Need to update mitigation of file editors extensionFactory issue before release #1060

krassowski opened this issue Feb 25, 2024 · 0 comments · Fixed by #1061
Labels
release-blocker Let's fix it before the next release!

Comments

@krassowski
Copy link
Member

In #1057 a workaround calling the editorAdded signal was added:

protected async initOnceReady(): Promise<void> {
await super.initOnceReady();
// Workaround for
// https://github.com/jupyterlab/jupyterlab/issues/15868
// remove once fixed upstream
this._editorAdded.emit({
editor: this.activeEditor
});
}

but once this is emitted upstream after jupyterlab/jupyterlab#15868 gets fixed, we could be in an incorrect state of two copies of each CM6 extension getting added to the editor.

We need to either:

  • wait with a release for an upstream fix to land
  • devise a way to make this workaround only apply when upstream does not handle it on it's own
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker Let's fix it before the next release!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant