Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance tests are failing on Windows with Python 3.8 (but pass with Python 3.11) #1059

Closed
krassowski opened this issue Feb 25, 2024 · 2 comments

Comments

@krassowski
Copy link
Member

Description

With #1057 our tests are passing again - all but one.

On Windows with Python 3.8 a number of tests, mostly related to completion, fails even after 3 re-runs.

Python 3.8 will be EOL later this year (2024-10) so we might as well try moving to 3.9.

Windows_38                                                                                                              
========================================================================================================================
Windows_38.05 Features                                                                                                  
========================================================================================================================
Windows_38.05 Features.Signature                                                                                        
========================================================================================================================
Triggered Signature Is Visible In First Cell                                                                    | FAIL |
Keyword 'Page Should Contain Element' failed after retrying 20 times. The last error was: Page should have contained element 'css:.lsp-signature-help' but did not.
------------------------------------------------------------------------------------------------------------------------
Windows_38.05 Features.Signature                                                                                | FAIL |
1 test, 0 passed, 1 failed
========================================================================================================================
Windows_38.05 Features.Highlights                                                                                       
========================================================================================================================
Highlights are modified after typing                                                                            | FAIL |
Element 'xpath://span[contains(@class, 'cm-lsp-highlight-Read') or contains(@class, 'cm-lsp-highlight-Write') or contains(@class, 'cm-lsp-highlight-Text')][contains(text(), 'testa')]' did not appear in 15 seconds.
------------------------------------------------------------------------------------------------------------------------
Windows_38.05 Features.Highlights                                                                               | FAIL |
1 test, 0 passed, 1 failed
========================================================================================================================
Windows_38.05 Features.Completion                                                                                       
========================================================================================================================
Autocompletes If Only One Option                                                                                | FAIL |
Element 'css:.jp-Completer.jp-HoverBox .jp-Completer-item[data-value="clear"]' did not appear in 10 seconds.
------------------------------------------------------------------------------------------------------------------------
Completes In Strings Or Python Dictionaries                                                                     | FAIL |
Element 'css:.jp-Completer.jp-HoverBox' did not appear in 35 seconds.
------------------------------------------------------------------------------------------------------------------------
Continuous Hinting Works                                                                                        | FAIL |
Element 'css:.jp-Completer.jp-HoverBox .jp-Completer-item[data-value="__doc__"]' did not appear in 10 seconds.
------------------------------------------------------------------------------------------------------------------------
Completes Paths In Strings                                                                                      | FAIL |
Element 'css:.jp-Completer.jp-HoverBox' did not appear in 35 seconds.
------------------------------------------------------------------------------------------------------------------------
Does Not Autocomplete If Multiple Options                                                                       | FAIL |
Element 'css:.jp-Completer.jp-HoverBox .jp-Completer-item[data-value="copy"]' did not appear in 10 seconds.
------------------------------------------------------------------------------------------------------------------------
Works With Incorrect Theme                                                                                      | FAIL |
Element 'css:.jp-Completer.jp-HoverBox .jp-Completer-item[data-value="TabError"]' did not appear in 10 seconds.
------------------------------------------------------------------------------------------------------------------------
Completion Works For Tokens Separated By Space                                                                  | FAIL |
Element 'css:.jp-Completer.jp-HoverBox .jp-Completer-item[data-value="import"]' did not appear in 10 seconds.
------------------------------------------------------------------------------------------------------------------------
Works After Kernel Restart In New Cells                                                                         | FAIL |
Element 'css:.jp-Completer.jp-HoverBox .jp-Completer-item[data-value="list"]' did not appear in 10 seconds.
------------------------------------------------------------------------------------------------------------------------
User Can Select Lowercase After Starting Uppercase                                                              | PASS |
------------------------------------------------------------------------------------------------------------------------
Works When Kernel Is Idle :: The suggestions from kernel and LSP should get integrated; operates in case ins... | FAIL |
Element 'css:.jp-Completer.jp-HoverBox .jp-Completer-item[data-value="TabError"]' did not appear in 10 seconds.
------------------------------------------------------------------------------------------------------------------------
Material Theme Works                                                                                            | FAIL |
Element 'css:.jp-Completer.jp-HoverBox .jp-Completer-item[data-value="TabError"]' did not appear in 10 seconds.
------------------------------------------------------------------------------------------------------------------------
Shows Only Relevant Suggestions In Known Magics                                                                 | FAIL |
Element 'css:.jp-Completer.jp-HoverBox' did not appear in 35 seconds.
------------------------------------------------------------------------------------------------------------------------
VSCode Dark Theme Works                                                                                         | FAIL |
Element 'css:.jp-Completer.jp-HoverBox .jp-Completer-item[data-value="TabError"]' did not appear in 10 seconds.
------------------------------------------------------------------------------------------------------------------------
Does Not Break Native Completions When Disabled                                                                 | FAIL |
Element 'css:.jp-Completer.jp-HoverBox .jp-Completer-item[data-value="try"]' did not appear in 10 seconds.
------------------------------------------------------------------------------------------------------------------------
Mid Token Completions Do Not Overwrite                                                                          | FAIL |
Element 'css:body[data-lsp-completer-layout]' did not appear in 5 seconds.
------------------------------------------------------------------------------------------------------------------------
VSCode Theme Works                                                                                              | FAIL |
Element 'css:.jp-Completer.jp-HoverBox .jp-Completer-item[data-value="TabError"]' did not appear in 10 seconds.
------------------------------------------------------------------------------------------------------------------------
Triggers Completer On Dot                                                                                       | FAIL |
Element 'css:.jp-Completer.jp-HoverBox' did not appear in 35 seconds.
------------------------------------------------------------------------------------------------------------------------
Can Prioritize LSP Completions                                                                                  | FAIL |
'246 > 270' should be true.
------------------------------------------------------------------------------------------------------------------------
Works Without A Theme                                                                                           | FAIL |
Element 'css:.jp-Completer.jp-HoverBox .jp-Completer-item[data-value="TabError"]' did not appear in 10 seconds.
------------------------------------------------------------------------------------------------------------------------
Windows_38.05 Features.Completion                                                                               | FAIL |
19 tests, 1 passed, 18 failed
========================================================================================================================
Windows_38.05 Features                                                                                          | FAIL |
21 tests, 1 passed, 20 failed
========================================================================================================================
Windows_38                                                                                                      | FAIL |
21 tests, 1 passed, 20 failed
@krassowski
Copy link
Member Author

Interestingly, all passed in #1051. Let's see what happens on main after that PR got merged.

@krassowski
Copy link
Member Author

It looks it was just a fluke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant