Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other social coding providers than GitHub #1480

Open
almereyda opened this issue Oct 1, 2021 · 3 comments
Open

Support other social coding providers than GitHub #1480

almereyda opened this issue Oct 1, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@almereyda
Copy link

almereyda commented Oct 1, 2021

Description / Summary

Currently all repository related configuration options assume GitHub as the primary means of distributing Jupyter Books.

This is visible through

and the GitHub branding of the icons used for the hovering dropdown menu, and for the repository link as well.

A configuration option to choose icons of other social coding providers, such as GitLab, plus eventually a generic, non-git related icon may increase understanding of this visual cue on the screen.

This could also mean to officially support GitLab CI/CD and have recipies available for GitLab pages, similar to those also available for Netlify. This is especially relevant for the documentation on these pages:

Value / benefit

This may increase adoption of Jupyter Books on other Git environments than GitHub.

Implementation details

  • Add a configuration option to choose from a list of icons.
  • Create or choose a generic icon that depicts the information to be conveyed for the term "repository" and one for the menu itself.

Tasks to complete

No response

@almereyda almereyda added the enhancement New feature or request label Oct 1, 2021
@welcome
Copy link

welcome bot commented Oct 1, 2021

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@firasm
Copy link
Contributor

firasm commented Oct 24, 2021

Thanks @almereyda ! I agree this is a good idea for the future.

In the meantime, I suggest looking at #1416 where @rickdkk and @NikosAlexandris have created a JB on GitLab using its' CI! Very cool.

@almereyda
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants