Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather client, kernel, and server coverage during acceptance tests #88

Closed
nrbgt opened this issue May 15, 2023 · 1 comment
Closed

Gather client, kernel, and server coverage during acceptance tests #88

nrbgt opened this issue May 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@nrbgt
Copy link
Contributor

nrbgt commented May 15, 2023

Elevator Pitch

Add an instrumented frontend build with istanbuljs and reporting with nyc. Run the jupyter_server and ipykernel processes under coverage.

Motivation

At present, the frontend has no assessment of test coverage, and the backend coverage from unit tests is lower than what is actually covered.

Design Ideas

  • add any additional webpack tools to gather coverage
  • add some robot keywords to capture coverage for frontend and backend
    • may need a custom kernel launcher
  • combine and report frontend coverage
  • consider using codecov, etc. for capturing coverage trends

For some concrete examples, see jupyterlab-deck.

@nrbgt nrbgt added the enhancement New feature or request label May 15, 2023
@nrbgt
Copy link
Contributor Author

nrbgt commented May 25, 2023

Fixed by #89

@nrbgt nrbgt closed this as completed May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant