Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.11 #512

Closed
marcphilipp opened this issue Sep 23, 2012 · 25 comments
Closed

Release 4.11 #512

marcphilipp opened this issue Sep 23, 2012 · 25 comments
Assignees

Comments

@marcphilipp
Copy link
Member

No description provided.

@marcphilipp
Copy link
Member Author

@dsaff @stefanbirkner Would you mind taking a look at the current (unfinished) version of the release notes?

@marcphilipp
Copy link
Member Author

I've updated the gist (see description above) once again.

@dsaff Please have a look to see if it contains pretty much what you expected. Please also check for spelling/grammar errors as I am not a native speaker. Thanks! :-)

@marcphilipp
Copy link
Member Author

@dsaff I would really like to publish beta1 this weekend. Do you have time to review the preliminary release notes or shall I go ahead and publish them with the beta?

@dsaff
Copy link
Member

dsaff commented Oct 11, 2012

Marc,

I'm really sorry to have stretched this out so long. I kept thinking I'd have time to go over the commit list and look for gaps, but it hasn't happened yet. These look like the big changes, and what's there is great. How secure are you that there's nothing overlooked? If you're pretty comfortable, go for it.

@marcphilipp
Copy link
Member Author

David, I understand, no worries. I've looked through the complete diff which was very large. I must admit that I am not 100% sure that I have not overlooked something. I deliberately left out a couple of ”minor“ changes that are only relevant for writers of other test frameworks that use JUnit. However, I am pretty sure that I have collected the major changes that are relevant for ”regular“ users. Thus, my suggestion would be to release beta1 along with the current state of the release notes. If anything is missing I think there will be someone telling us. In addition, I would try to use some Git magic to collect all authors and ask them whether their contribution has been documented appropriately. What do you think?

@marcphilipp
Copy link
Member Author

Submitted the release notes draft to the repository in #524.

@marcphilipp
Copy link
Member Author

Tried to release 4.11-beta-1 through Sonatype's staging repository. Unfortunately, I got the following error message:

Staging ruleset evaluation on repository 'junit-148 (u:marcphilipp, a:78.53.210.99)' has failed.

Staging Javadoc Validation
    -Missing: no main jar artifact found in folder '/junit/junit-dep/4.11-beta-1'

Staging Sources Validation
    -Missing: no main jar artifact found in folder '/junit/junit-dep/4.11-beta-1'

Staging POM Validation
    -Invalid POM: /junit/junit-dep/4.11-beta-1/junit-dep-4.11-beta-1.pom: Project name missing, Project description missing, Project URL missing, License information missing, SCM URL missing, Developer information missing

Apparently the relocation of junit:junit-dep to junit:junit is causing problems. I will open a ticket at Sonatype's and ask for help.

@marcphilipp
Copy link
Member Author

Here's the corresponding entry in Sonatype's JIRA:
https://issues.sonatype.org/browse/OSSRH-4501

@marcphilipp
Copy link
Member Author

@dsaff Apparently the packaging-type of the junit:junit-dep artifact was wrong. I have submitted a small pull request (#525) to fix the corresponding POM template. Could you have a look and merge it? I have already tested it by pushing a snapshot to Sonatype's snapshot repository and used it in a test project.

@dsaff
Copy link
Member

dsaff commented Oct 15, 2012

Done, thanks!

@marcphilipp
Copy link
Member Author

I have submitted 4.11-beta-1 to Maven central and uploaded the files to GitHub. I also sent an announcement to the JUnit mailing list. Keep your fingers crossed... ;-)

@lennartdiedrich
Copy link

What do you think how long does it take until the beta-1 is accessible at maven central?

@marcphilipp
Copy link
Member Author

They said it would take one to two hours. It's already in Sonatype's releases repo: https://oss.sonatype.org/content/repositories/releases/

@lennartdiedrich
Copy link

Okay. Thank you Marc for putting a little pressure on this release. IMHO it was a little bit overdue.

@marcphilipp
Copy link
Member Author

I had the same feeling, we should definitely have an open discussion about releasing more often.

@marcphilipp
Copy link
Member Author

@dsaff I have submitted yet another pull request that makes the release notes easier to read on GitHub by simply changing the file extension: #526.

@marcphilipp
Copy link
Member Author

I pushed another version of the release notes that includes the changes done after 4.11-beta-1: #543.

@dsaff As soon as #543 is merged, I will release 4.11.

@marcphilipp
Copy link
Member Author

Starting to release 4.11 now.

@dsaff Who can update junit.org? Who can upload the release to SourceForge?

@dsaff
Copy link
Member

dsaff commented Nov 14, 2012

junit.org seems to be having bigger problems at this very moment, which I'm trying to keep tabs on.

I just updated the SourceForge site to effectively sunset it in favor of github. I'll beg forgiveness later if anyone complains.

We should put a couple links at the top of https://github.com/KentBeck/junit/wiki: release notes (for now, just for 4.11, although we should eventually link them all in there), and how to download/install. Do you have time to do that? Then, I'll try to get junit.org to point there.

How's that sound?

@dsaff
Copy link
Member

dsaff commented Nov 14, 2012

Very exciting to see this done. Thank you very much!

@marcphilipp
Copy link
Member Author

Sounds like a good start, I'm starting to update the wiki right now.

@dsaff To me it seems the SourceForge site is unchanged... Will it take some time for the changes to appear?

@dsaff
Copy link
Member

dsaff commented Nov 14, 2012

It shows changed to me. On https://sourceforge.net/projects/junit/?source=directory, I see "We are deprecating our SourceForge installation." Do you?

@marcphilipp
Copy link
Member Author

Yes, I can see it now. Wasn't there when I asked... ;-)

@marcphilipp
Copy link
Member Author

Updated the wiki, feel free to tweak it to your likings.

Can we close this issue?

@dsaff
Copy link
Member

dsaff commented Nov 14, 2012

Beautiful. Closed. Thanks, @marcphilipp

@dsaff dsaff closed this as completed Nov 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants