Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems finding license on Windows #275

Closed
trulsf opened this issue Aug 27, 2024 · 4 comments · Fixed by #276
Closed

Problems finding license on Windows #275

trulsf opened this issue Aug 27, 2024 · 4 comments · Fixed by #276
Assignees

Comments

@trulsf
Copy link

trulsf commented Aug 27, 2024

With the recent version (0.17.0) there is a problem detecting the license file with a standard installation for Windows (not using the Xpress_jll). The environment variable XPRESSDIR will by default be set to the folder of the installation (e.g 'c:\xpressmp') while the license file resides in the 'bin' folder ('c:\xpressmp\bin').

I guess this could be added as one of the candidate locations of the license checking in 'license.jl'. The specific check for Windows based on the use of libdir does not work as the value is empty ("").

@odow
Copy link
Member

odow commented Aug 27, 2024

Okay. Looks like we can just add a new line after

Xpress.jl/src/license.jl

Lines 24 to 26 in c885d03

# Search in `xpress/lib/../bin/xpauth.xpr`. This is a common location on
# Windows.
push!(candidates, joinpath(dirname(libdir), "bin", XPAUTH))

@jd-lara
Copy link
Collaborator

jd-lara commented Sep 19, 2024

same is happening in Mac

@odow odow self-assigned this Sep 19, 2024
@odow
Copy link
Member

odow commented Sep 19, 2024

I'll fix this now

@odow
Copy link
Member

odow commented Sep 19, 2024

Can you try #276?

@odow odow closed this as completed in #276 Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants