Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nlp-expr/003_014.jl and nlp-expr/003_015.jl are identical #51

Closed
cvanaret opened this issue Nov 13, 2024 · 2 comments · Fixed by #52
Closed

nlp-expr/003_014.jl and nlp-expr/003_015.jl are identical #51

cvanaret opened this issue Nov 13, 2024 · 2 comments · Fixed by #52

Comments

@cvanaret
Copy link

No description provided.

@ccoffrin
Copy link
Collaborator

I think this is a bug in the test. The comments suggest that 003_015 should be using @NLobjective instead of @objective. However, if that does not make sense, then I agree one these tests can be removed.

CC @odow

@odow
Copy link
Member

odow commented Nov 13, 2024

They were different in https://github.com/jump-dev/MINLPTests.jl/blob/master/src/nlp/003_014.jl and https://github.com/jump-dev/MINLPTests.jl/blob/master/src/nlp/003_015.jl.

When I updated them all to use the new nonlinear interface I didn't audit for unneeded tests.

We can remove_015, but having a duplicate isn't the end of the world.

@odow odow mentioned this issue Nov 13, 2024
Merged
@odow odow closed this as completed in #52 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete src/nlp-expr/003_015.jl jump-dev/MINLPTests.jl
3 participants
@ccoffrin @odow @cvanaret