Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export of Private Macros #2023

Closed
ccoffrin opened this issue Aug 11, 2019 · 2 comments · Fixed by #2270
Closed

Export of Private Macros #2023

ccoffrin opened this issue Aug 11, 2019 · 2 comments · Fixed by #2270
Assignees
@mlubin

Comments

@ccoffrin
Copy link
Contributor

Should this line,

    if sym in _EXCLUDE_SYMBOLS || startswith(sym_string, "_") ...

include || startswith(sym_string, "@_") so that a package can have internal non-exported macros?
@mlubin
Copy link
Member

mlubin commented Aug 12, 2019

Yes, looks like an oversight. We've already been naming internal macros with underscores:
https://github.com/JuliaOpt/JuMP.jl/blob/79a4fe4d4fc11bc96b62a88b085734429a833dd2/src/macros.jl#L987-L994

@odow
Copy link
Member

odow commented Jul 1, 2020

I guess this is a breaking change, but it shouldn't hit anyone because they shouldn't be using the macros beginning with an underscore.

Task:

  • Add what @ccoffrin says

@mlubin mlubin self-assigned this Jul 11, 2020
@mlubin mlubin mentioned this issue Jul 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlubin mlubin

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't export macros whose names start with underscores jump-dev/JuMP.jl
3 participants
@ccoffrin @mlubin @odow