-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to MOI v0.10 #467
Update to MOI v0.10 #467
Conversation
…19-579-03583683988
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
- Coverage 92.36% 91.82% -0.55%
==========================================
Files 83 83
Lines 5136 5137 +1
==========================================
- Hits 4744 4717 -27
- Misses 392 420 +28
Continue to review full report at Codecov.
|
I think the GLPK failures (https://github.com/jump-dev/Convex.jl/runs/4200633319?check_suite_focus=true#step:6:1088) are GLPK issues, not Convex issues, since those tests pass with SCS; likewise, the nightly failure and SCS failure on the lieb ando problem isn't a Convex issue, since nothing there has changed. I'll update ConvexTests to try to surface these issues and file issues for the solvers. I think this is good to go (assuming the docs build passes; at the time of writing it is still going, but the non-nightly tests have passed). |
Is that really it? I'm surprised. I'll make a new release of GLPK. |
Yeah, the interface with MOI is fairly minimal, so I guess that has helped. That's since we do most things with our internal data structures and then emit a MBP-style conic problem, instead of using MOI bridges for more of our reformulations. Usually that's been a bad thing (since we can't support all the things that MOI could allow us to via bridges) but here I guess it's been convenient 😄. |
Closes #454
Closes #466
Seems like it's not too bad! Or I haven't gotten to the tests that will fail yet.