Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VariableConstraints #118

Closed
blegat opened this issue Jul 15, 2021 · 1 comment
Closed

VariableConstraints #118

blegat opened this issue Jul 15, 2021 · 1 comment

Comments

@blegat
Copy link
Member

blegat commented Jul 15, 2021

The following four fields:
https://github.com/jump-dev/MathOptInterface.jl/blob/a1d3ed961176f65ec9f74afad455ecedbb1ce8d3/src/Utilities/model.jl#L993-L1001
are quite independent from the rest and constitute a representation of SingleVariable constraints.
Many MOI wrapper reimplement that part with the VariableInfo struct. Instead of copy-pasting this VariableInfo struct implementation in all these wrappers, we could create a ModelLike in MOI.Utilities containing these 4 fields, replace these four fields by this struct in GenericModel, and use this struct as well in all wrappers.
This will greatly simplify many wrappers and ensure that their behavior with SingleVariable constraint is consistent with GenericModel and as fast as GenericModel by design.
@odow
Copy link
Member

odow commented Nov 4, 2021

Closed by #114

@odow odow closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blegat @odow