Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Compliance with the OpenID Connect Standard #169

Open
kmzs opened this issue Jun 26, 2019 · 0 comments
Open

Non-Compliance with the OpenID Connect Standard #169

kmzs opened this issue Jun 26, 2019 · 0 comments

Comments

@kmzs
Copy link

kmzs commented Jun 26, 2019

The library is not fully compliant to the OpenID Connect standard.
The following aspects differ from the standard:

  1. The ID Token must contain the two timestamps iat and exp (see here). The library does not strictly enforce the presence of the exp claim and does not consider the iat at all. Instead the nbf claim used (L932 + L933). This claim is described in the JWT standard (RFC 7519) but not explicitly part of an ID Token according to the OpenID Connect standard.
  2. The library does not take into account that the Authorization Code Flow and Implicit Flow require different parameters to be present. When using the Implicit Flow both nonce and at_hash are mandatory claims (see here) while they are optional when the Authorization Code Flow is used (see here and here).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant