Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images: accept BMP format #1226

Closed
xaviermiller opened this issue Jan 4, 2024 · 2 comments
Closed

Images: accept BMP format #1226

xaviermiller opened this issue Jan 4, 2024 · 2 comments
Assignees
Labels
feature New feature or request

Comments

@xaviermiller
Copy link

Is your new feature related to a problem? Please describe.
For now, RecipeSage does not support BMP file format. The images are silently ignored.

Describe the solution you'd like
Provide an error message or import / convert them

Describe alternatives you've considered
Now I need to convert BMP images to PNG before to load them in recipes

Additional context
Add any other context or screenshots/mockups for the new feature here.

@julianpoy
Copy link
Owner

Errors are only ignored during DB imports, but do throw an error when uploading individual images.

Support for BMP is a little challenging. See this issue for sharp (the conversion library we use): lovell/sharp#806

@xaviermiller
Copy link
Author

OK, I will convert all my images to PNG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants