Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stat: filesTotal #2

Open
juliangruber opened this issue Sep 21, 2016 · 2 comments
Open

stat: filesTotal #2

juliangruber opened this issue Sep 21, 2016 · 2 comments

Comments

@juliangruber
Copy link
Owner 

archive.list().on('data', entry => { stats.filesTotal++ })
@joehand
Copy link
Collaborator

joehand commented Sep 21, 2016

For this and the filesProgress, #1, we need to decide if its "files" or "entries" (directories + files). I'm not sure I care either way, but if we do entries we should name it accordingly: itemsTotal or entriesTotal.

@juliangruber
Copy link
Owner Author

What about we make it filesTotal and directoriesTotal? This way you can compute an entriesTotal if you want. Downside is just that it's one property more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juliangruber @joehand