Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicitly return slice/array #4

Closed
cmin764 opened this issue Oct 5, 2019 · 2 comments
Closed

Implicitly return slice/array #4

cmin764 opened this issue Oct 5, 2019 · 2 comments

Comments

@cmin764
Copy link
Contributor

cmin764 commented Oct 5, 2019

Is there any obvious reason for which the intersection returns an interface{} instead of []interface{}? I think each time we do an intersection we expect to end up with an array/slice and not manually make that conversion each time.
Maybe I'm missing some casting edge-cases where this generic response makes sense.

@juliangruber
Copy link
Owner

Good point, I don't think it needs to be interface{}. Do you want to try this in a PR?

@cmin764
Copy link
Contributor Author

cmin764 commented Oct 8, 2019

Yes, how about this: #5 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants