You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
my enterprise auth page uses JQuery
when i launch prospect-mail the auth page is not loading correctly and i'm unable to logging in
when launch prospect-mail with --enable-logging it's clear it's a problem related to jquery
[44559:1107/140954.990131:INFO:CONSOLE(6)] "Uncaught ReferenceError: jQuery is not defined"
i've found two useful ressources about issue with Electron and JQuery :
directly from the electronjs FAQ, I apply the following recommandation :
"To solve this, you can turn off node integration in Electron"
so in "src/controller/mail-window-controller.js" (line 94)
i change the value of 'nodeIntegration' from 'true' to 'false'
and my local instance of prospect-mail is working !! i see no evident bad effect after few minutes of use.
Describe the solution you'd like
I'm not very familiar with Electron, i not aware of the consequences of my change
if prospect-mail can work correctly with nodeIntegration set to false,
is it possible to set the wanted value of nodeIntegration in settings file ?
Describe alternatives you've considered
without this change i'm unable to use prospect mail
The text was updated successfully, but these errors were encountered:
niconil
changed the title
[Feature Request]: setting nodeIntegration in settings
[Feature Request]: choose nodeIntegration value in settings
Nov 7, 2023
I was following #299 but this is a more generic description of the overall problem. Having a look, I think that #316, #311 and probably #303 are duplicate of this same overall problem.
As far as I'm concerned, checking out #314 and storing the following new implemented setting in my ~/.config/Prospect Mail/settings.json file fixes the issue (i.e. getting directed to my company saml login and correctly following all redirection untill login is successful):
{
"contextIsolation": true
}
This setting should probably be the default value as this is the case anyway if you don't provide this value when creating a BrowserWindow instance.
Since this is currently striking me only every now and then when I have to rotate my password and that the latest version works correctly once authenticated, here is how I work around the problem using the snap version for whomever it might help until the above is merged.
Is your feature request related to a problem? Please describe.
my enterprise auth page uses JQuery
when i launch prospect-mail the auth page is not loading correctly and i'm unable to logging in
when launch prospect-mail with --enable-logging it's clear it's a problem related to jquery
[44559:1107/140954.990131:INFO:CONSOLE(6)] "Uncaught ReferenceError: jQuery is not defined"
i've found two useful ressources about issue with Electron and JQuery :
directly from the electronjs FAQ, I apply the following recommandation :
"To solve this, you can turn off node integration in Electron"
so in "src/controller/mail-window-controller.js" (line 94)
i change the value of 'nodeIntegration' from 'true' to 'false'
and my local instance of prospect-mail is working !! i see no evident bad effect after few minutes of use.
Describe the solution you'd like
I'm not very familiar with Electron, i not aware of the consequences of my change
if prospect-mail can work correctly with nodeIntegration set to false,
is it possible to set the wanted value of nodeIntegration in settings file ?
Describe alternatives you've considered
without this change i'm unable to use prospect mail
The text was updated successfully, but these errors were encountered: